netdev - Re: [PATCH net-next 0/4] net/smc: fixes 2018/04/30

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <221a8063-d526-16bf-05d2-12e6229b773b@linux.ibm.com>
Date:   Wed, 2 May 2018 16:53:43 +0200
From:   Ursula Braun <ubraun@...ux.ibm.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
        raspl@...ux.ibm.com
Subject: Re: [PATCH net-next 0/4] net/smc: fixes 2018/04/30

On 05/01/2018 03:03 AM, David Miller wrote:
> From: Ursula Braun <ubraun@...ux.ibm.com>
> Date: Mon, 30 Apr 2018 16:51:15 +0200
> 
>> From: Ursula Braun <ursula.braun@...ux.ibm.com>
>>
>> Dave,
>>
>> here are 4 smc patches for net-next covering different areas:
>>    * link health check
>>    * diagnostics for IPv6 smc sockets
>>    * ioctl
>>    * improvement for vlan determination
> 
> You say "fixes" in your Subject line but adding ipv6 smc
> socket diag support is a feature not a fix.

Sorry, I just reused my old subject pattern without reflecting it.
These 4 patches are new features for SMC, and thus the title
should have been "net/smc: features 2018/04/30".

I am going to send v2 with such a title.

> 
> Actually, generally speaking your patch submissions are
> confusing.
> 
> You do submit really pure bug fixes, but for some odd
> reason you target the net-next tree instead of net.
>

> Maybe you have a good reason for doing this and you can
> explain it to me?
> 

Currently we just have one patch queue for upstream posting and
do not separate smc bug fixes from smc features. It is easier to
keep this patch queue and send them for net-next. Thus in the past
I have submitted bug fixes regarded as minor for net-next as well.
But in future I will send pure bug fixes always for net.