netdev - Re: [PATCH net] sctp: use the old asoc when making the cookie-ack chunk in dupcook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180502.111645.2168255311623555739.davem@davemloft.net>
Date:   Wed, 02 May 2018 11:16:45 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
        marcelo.leitner@...il.com, nhorman@...driver.com
Subject: Re: [PATCH net] sctp: use the old asoc when making the cookie-ack
 chunk in dupcook_d

From: Xin Long <lucien.xin@...il.com>
Date: Wed,  2 May 2018 13:39:46 +0800

> When processing a duplicate cookie-echo chunk, for case 'D', sctp will
> not process the param from this chunk. It means old asoc has nothing
> to be updated, and the new temp asoc doesn't have the complete info.
> 
> So there's no reason to use the new asoc when creating the cookie-ack
> chunk. Otherwise, like when auth is enabled for cookie-ack, the chunk
> can not be set with auth, and it will definitely be dropped by peer.
> 
> This issue is there since very beginning, and we fix it by using the
> old asoc instead.
> 
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied and queued up for -stable.