netdev - Re: [PATCH net 1/1] net/smc: restrict non-blocking connect finish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180502.132817.1973402419020011208.davem@davemloft.net>
Date:   Wed, 02 May 2018 13:28:17 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ubraun@...ux.ibm.com
Cc:     netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
        raspl@...ux.ibm.com
Subject: Re: [PATCH net 1/1] net/smc: restrict non-blocking connect finish

From: Ursula Braun <ubraun@...ux.ibm.com>
Date: Wed,  2 May 2018 16:53:56 +0200

> The smc_poll code tries to finish connect() if the socket is in
> state SMC_INIT and polling of the internal CLC-socket returns with
> EPOLLOUT. This makes sense for a select/poll call following a connect
> call, but not without preceding connect().
> With this patch smc_poll starts connect logic only, if the CLC-socket
> is no longer in its initial state TCP_CLOSE.
> 
> In addition, a poll error on the internal CLC-socket is always
> propagated to the SMC socket.
> 
> With this patch the code path mentioned by syzbot
> https://syzkaller.appspot.com/bug?extid=03faa2dc16b8b64be396
> is no longer possible.
> 
> Signed-off-by: Ursula Braun <ubraun@...ux.ibm.com>
> Reported-by: syzbot+03faa2dc16b8b64be396@...kaller.appspotmail.com

Applied and queued up for -stable, thanks.