netdev - Re: [PATCH net] ipv6: Revert "ipv6: Allow non-gateway ECMP for IPv6"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06ce7e15-92f3-116a-21d0-5090f33ce845@gmail.com>
Date:   Wed, 2 May 2018 12:50:18 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Ido Schimmel <idosch@...lanox.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, dsahern@...il.com, eric.dumazet@...il.com,
        Thomas.Winter@...iedtelesis.co.nz, mlxsw@...lanox.com
Subject: Re: [PATCH net] ipv6: Revert "ipv6: Allow non-gateway ECMP for IPv6"



On 05/02/2018 12:41 PM, Ido Schimmel wrote:
> This reverts commit edd7ceb78296 ("ipv6: Allow non-gateway ECMP for
> IPv6").
> 
> Eric reported a division by zero in rt6_multipath_rebalance() which is
> caused by above commit that considers identical local routes to be
> siblings. The division by zero happens because a nexthop weight is not
> set for local routes.
> 
> Revert the commit as it does not fix a bug and has side effects.
> 
> To reproduce:
> 
> # ip -6 address add 2001:db8::1/64 dev dummy0
> # ip -6 address add 2001:db8::1/64 dev dummy1
> 
> Fixes: edd7ceb78296 ("ipv6: Allow non-gateway ECMP for IPv6")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Reported-by: Eric Dumazet <eric.dumazet@...il.com>
> ---

Tested-by: Eric Dumazet <edumazet@...gle.com>

Thanks for fixing this !