netdev - Re: [PATCH net-next] udp: Complement partial checksum for GSO packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-K+15L9Ui227y04fhrQjCMa5WGyT+rydvM17BF94E8yLw@mail.gmail.com>
Date:   Wed, 2 May 2018 11:25:43 +0200
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Sean Tranchetti <stranche@...eaurora.org>
Cc:     Willem de Bruijn <willemb@...gle.com>,
        David Miller <davem@...emloft.net>,
        Network Development <netdev@...r.kernel.org>,
        Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
Subject: Re: [PATCH net-next] udp: Complement partial checksum for GSO packet

On Tue, May 1, 2018 at 12:06 PM, Willem de Bruijn
<willemdebruijn.kernel@...il.com> wrote:
> On Tue, May 1, 2018 at 2:01 AM, Sean Tranchetti <stranche@...eaurora.org> wrote:
>> Using the udp_v4_check() function to calculate the pseudo header
>> for the newly segmented UDP packets results in assigning the complement
>> of the value to the UDP header checksum field.
>>
>> Always undo the complement the partial checksum value in order to
>> match the case where GSO is not used on the UDP transmit path.
>>
>> Fixes: ee80d1ebe5ba ("udp: add udp gso")
>> Signed-off-by: Sean Tranchetti <stranche@...eaurora.org>
>> Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>

Acked-by: Willem de Bruijn <willemb@...gle.com>

Thanks Sean.