netdev - Re: [PATCH net-next mlxsw v2 2/2] net: bridge: Notify about !added_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <wih4ljosxa1.fsf@dev-r-vrt-156.mtr.labs.mlnx>
Date:   Thu, 03 May 2018 16:07:18 +0300
From:   Petr Machata <petrm@...lanox.com>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:     netdev@...r.kernel.org, bridge@...ts.linux-foundation.org,
        jiri@...lanox.com, idosch@...lanox.com, ivecera@...hat.com,
        davem@...emloft.net, stephen@...workplumber.org, andrew@...n.ch,
        vivien.didelot@...oirfairelinux.com, f.fainelli@...il.com
Subject: Re: [PATCH net-next mlxsw v2 2/2] net: bridge: Notify about !added_by_user FDB entries

Nikolay Aleksandrov <nikolay@...ulusnetworks.com> writes:

> On 03/05/18 15:43, Petr Machata wrote:
>> Do not automatically bail out on sending notifications about activity on
>> non-user-added FDB entries. Instead, notify about this activity except
>> for cases where the activity itself originates in a notification, to
>> avoid sending duplicate notifications.
>>
>> Signed-off-by: Petr Machata <petrm@...lanox.com>
>> ---
>>   net/bridge/br.c           |  4 ++--
>>   net/bridge/br_fdb.c       | 47 ++++++++++++++++++++++++++---------------------
>>   net/bridge/br_private.h   |  6 ++++--
>>   net/bridge/br_switchdev.c |  2 +-
>>   4 files changed, 33 insertions(+), 26 deletions(-)
>>
>
> Thanks, looks good to me! In the future please add the reviewers to the CC list
> when sending a v2, I actually missed the v2 set and saw your reply to the cover
> letter patch later.

Sorry, I'm still tweaking my process for direct submission after going
almost exclusively through mlxsw for so long!

> Acked-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>

Thanks,
Petr