netdev - Re: [PATCH v1 net-next] net: dsa: mv88e6xxx: 88E6141/6341 SERDES support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180503131515.GB17027@lunn.ch>
Date:   Thu, 3 May 2018 15:15:15 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Marek Behún <marek.behun@....cz>
Cc:     netdev@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        Arkadi Sharshevsky <arkadis@...lanox.com>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH v1 net-next] net: dsa: mv88e6xxx: 88E6141/6341 SERDES
 support

On Thu, May 03, 2018 at 03:06:48PM +0200, Marek Behún wrote:
> The 88E6141/6341 switches (also known as Topaz) have 1 SGMII lane,
> which can be configured the same way as the SERDES lane on 88E6390.
> 
> Signed-off-by: Marek Behun <marek.behun@....cz>

> +int mv88e6341_serdes_power(struct mv88e6xxx_chip *chip, int port, bool on)
> +{
> +	int err;
> +	u8 cmode;
> +
> +	if (port != 5)
> +		return 0;
> +
> +	err = mv88e6xxx_port_get_cmode(chip, port, &cmode);
> +	if (err)
> +		return err;
> +
> +	if ((cmode == MV88E6XXX_PORT_STS_CMODE_1000BASE_X) ||
> +	     (cmode == MV88E6XXX_PORT_STS_CMODE_SGMII) ||
> +	     (cmode == MV88E6XXX_PORT_STS_CMODE_2500BASEX))
> +		return mv88e6390_serdes_sgmii(chip, 0x15, on);

Hi Marek

Please add a #define for this 0x15.

Otherwise, this looks good.

	   Andrew