netdev - Re: [PATCH 2/2] drivers core: multi-threading device shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGM2reYu8uNuasJmsrJ8nzSJ5Zs2466D=ytgG21dJCd+7RO7fQ@mail.gmail.com>
Date:   Thu, 03 May 2018 13:38:35 +0000
From:   Pavel Tatashin <pasha.tatashin@...cle.com>
To:     tobin@...orbit.com
Cc:     Steven Sistare <steven.sistare@...cle.com>,
        Daniel Jordan <daniel.m.jordan@...cle.com>,
        LKML <linux-kernel@...r.kernel.org>, jeffrey.t.kirsher@...el.com,
        intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        gregkh@...uxfoundation.org
Subject: Re: [PATCH 2/2] drivers core: multi-threading device shutdown

On Thu, May 3, 2018 at 1:54 AM Tobin C. Harding <tobin@...orbit.com> wrote:

> This code was a pleasure to read, super clean.

Hi Tobin,

Thank you very much for your review, I will address all of your comments in
the next revision.

BTW, I found  a lock ordering issue in my work that  that I will need to
fix:

In device_shutdown() device_lock() must be taken before
devices_kset->list_lock. Instead I will use device_trylock(), and if that
fails, will drop devices_kset->list_lock and acquiring the device lock
outside, and check that the device is still in the list after taking the
list lock again.

Pavel