netdev - Re: [PATCH net] tcp: restore autocorking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVnQy=yabdw=PBOmwvfEWGdxRtuQ7peFYA0tBGCMpSQqJt0cg@mail.gmail.com>
Date:   Thu, 03 May 2018 14:48:53 +0000
From:   Neal Cardwell <ncardwell@...gle.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>, mwenig@...are.com,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net] tcp: restore autocorking

On Wed, May 2, 2018 at 11:25 PM Eric Dumazet <edumazet@...gle.com> wrote:

> When adding rb-tree for TCP retransmit queue, we inadvertently broke
> TCP autocorking.

> tcp_should_autocork() should really check if the rtx queue is not empty.

...

> Fixes: 75c119afe14f ("tcp: implement rb-tree based retransmit queue")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Michael Wenig <mwenig@...are.com>
> Tested-by: Michael Wenig <mwenig@...are.com>
> ---

Acked-by: Neal Cardwell <ncardwell@...gle.com>

Nice. Thanks, Eric!

neal