netdev - Re: [PATCH V2] net/netlink: optimize seq_puts and seq_printf in af

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180503.125800.805006461069190790.davem@davemloft.net>
Date:   Thu, 03 May 2018 12:58:00 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     tsu.yubo@...il.com
Cc:     xiyou.wangcong@...il.com, yuzibode@....com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH V2] net/netlink: optimize seq_puts and seq_printf in
 af_netlink.c

From: YU Bo <tsu.yubo@...il.com>
Date: Thu, 3 May 2018 05:09:04 -0400

> Before the patch, the command `cat /proc/net/netlink` will output
> like:
> 
> https://clbin.com/BojZv
> 
> After the patch:
> 
> https://clbin.com/lnu4L
> 
> The optimization will make convenience for using `cat
> /proc/net/netlink`
> But,The checkpatch will give a warning:
> 
> WARNING: quoted string split across lines
> 
> Signed-off-by: Bo YU <tsu.yubo@...il.com>

Please do not reference external web sites for text which explains
the change in your commit message.

Simply show the /proc/net/netlink headers and then one line of the
output, before and after, in diff style.

Then it will be clear to the reader that you are not "optimizing"
anything.  This is not an optimization.

You are just making sure the headers line up properly with the
actual value output.

Thank you.