netdev - Re: [PATCH bpf-next v4 0/4] Hash support for sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180503.143123.1034749788277999334.davem@davemloft.net>
Date:   Thu, 03 May 2018 14:31:23 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     john.fastabend@...il.com
Cc:     borkmann@...earbox.net, ast@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v4 0/4] Hash support for sock

From: John Fastabend <john.fastabend@...il.com>
Date: Thu,  3 May 2018 11:28:24 -0700

> In the original sockmap implementation we got away with using an
> array similar to devmap. However, unlike devmap where an ifindex
> has a nice 1:1 function into the map we have found some use cases
> with sockets that need to be referenced using longer keys.
> 
> This series adds support for a sockhash map reusing as much of
> the sockmap code as possible. I made the decision to add sockhash
> specific helpers vs trying to generalize the existing helpers
> because (a) they have sockmap in the name and (b) the keys are
> different types. I prefer to be explicit here rather than play
> type games or do something else tricky.
> 
> To test this we duplicate all the sockmap testing except swap out
> the sockmap with a sockhash.
> 
> v2: fix file stats and add v2 tag
> v3: move tool updates into test patch, move bpftool updates into
>     its own patch, and fixup the test patch stats to catch the
>     renamed file and provide only diffs +/- on that.
> v4: Add documentation to UAPI bpf.h

Acked-by: David S. Miller <davem@...emloft.net>