netdev - Re: [PATCH net] dccp: fix tasklet usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180503.151525.1755893274006498102.davem@davemloft.net>
Date:   Thu, 03 May 2018 15:15:25 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        gerrit@....abdn.ac.uk, dccp@...r.kernel.org
Subject: Re: [PATCH net] dccp: fix tasklet usage

From: Eric Dumazet <edumazet@...gle.com>
Date: Thu,  3 May 2018 09:39:20 -0700

> syzbot reported a crash in tasklet_action_common() caused by dccp.
> 
> dccp needs to make sure socket wont disappear before tasklet handler
> has completed.
> 
> This patch takes a reference on the socket when arming the tasklet,
> and moves the sock_put() from dccp_write_xmit_timer() to dccp_write_xmitlet()
 ...
> Fixes: dc841e30eaea ("dccp: Extend CCID packet dequeueing interface")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied and queued up for -stable, thanks Eric.