netdev - [PATCH V2] net/netlink: optimize seq_puts and seq_printf in af

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180503090901.35bxgzs2tjsl7bqr@debian>
Date:   Thu, 3 May 2018 05:09:04 -0400
From:   YU Bo <tsu.yubo@...il.com>
To:     davem@...emloft.net, xiyou.wangcong@...il.com, yuzibode@....com,
        tsu.yubo@...il.com
Cc:     netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: [PATCH V2] net/netlink: optimize  seq_puts and seq_printf  in
 af_netlink.c

Before the patch, the command `cat /proc/net/netlink` will output like:

https://clbin.com/BojZv

After the patch:

https://clbin.com/lnu4L

The optimization will make convenience for using `cat /proc/net/netlink`
But,The checkpatch will give a warning:

WARNING: quoted string split across lines

Signed-off-by: Bo YU <tsu.yubo@...il.com>
---
Changes in v2:
Do not break the indentation of the code line
---
 net/netlink/af_netlink.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 55342c4d5cec..2e2dd88fc79f 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -2606,13 +2606,13 @@ static int netlink_seq_show(struct seq_file *seq, void *v)
 {
 	if (v == SEQ_START_TOKEN) {
 		seq_puts(seq,
-			 "sk       Eth Pid    Groups   "
-			 "Rmem     Wmem     Dump     Locks     Drops     Inode\n");
+			 "sk               Eth Pid        Groups   "
+			 "Rmem     Wmem     Dump  Locks    Drops    Inode\n");
 	} else {
 		struct sock *s = v;
 		struct netlink_sock *nlk = nlk_sk(s);

-		seq_printf(seq, "%pK %-3d %-6u %08x %-8d %-8d %d %-8d %-8d %-8lu\n",
+		seq_printf(seq, "%pK %-3d %-10u %08x %-8d %-8d %-5d %-8d %-8d %-8lu\n",
 			   s,
 			   s->sk_protocol,
 			   nlk->portid,
--
2.11.0