netdev - Re: [PATCH] net: ethernet: sun: niu set correct packet size in skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180504.125626.1889054644844307730.davem@davemloft.net>
Date:   Fri, 04 May 2018 12:56:26 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     rob@...lang.io
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: sun: niu set correct packet size in skb

From: Rob Taglang <rob@...lang.io>
Date: Thu, 03 May 2018 17:13:06 -0400

> Currently, skb->len and skb->data_len are set to the page size, not
> the packet size. This causes the frame check sequence to not be
> located at the "end" of the packet resulting in ethernet frame check
> errors. The driver does work currently, but stricter kernel facing
> networking solutions like OpenVSwitch will drop these packets as
> invalid.
> 
> These changes set the packet size correctly so that these errors no
> longer occur. The length does not include the frame check sequence, so
> that subtraction was removed.
> 
> Tested on Oracle/SUN Multithreaded 10-Gigabit Ethernet Network
> Controller [108e:abcd] and validated in wireshark.
> 
> Signed-off-by: Rob Taglang <rob@...lang.io>
> ---
>  drivers/net/ethernet/sun/niu.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sun/niu.c
> b/drivers/net/ethernet/sun/niu.c
> index f081de4..88c1247 100644
> --- a/drivers/net/ethernet/sun/niu.c
> +++ b/drivers/net/ethernet/sun/niu.c
> @@ -3443,7 +3443,7 @@ static int niu_process_rx_pkt(struct napi_struct
> *napi, struct niu *np,

Still corrupted.  Your email client is chopping up long lines.

Please, send a test patch to yourself and make sure you can apply the
patch that arrives in that test email.

Thank you.