netdev - Re: [PATCH net-next] liquidio: support use of ethtool to set link speed of CN23XX-225 cards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180504.130022.456100476632220937.davem@davemloft.net>
Date:   Fri, 04 May 2018 13:00:22 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     felix.manlunas@...ium.com
Cc:     netdev@...r.kernel.org, raghu.vatsavayi@...ium.com,
        derek.chickles@...ium.com, satananda.burla@...ium.com,
        weilin.chang@...ium.com
Subject: Re: [PATCH net-next] liquidio: support use of ethtool to set link
 speed of CN23XX-225 cards

From: Felix Manlunas <felix.manlunas@...ium.com>
Date: Thu, 3 May 2018 19:23:25 -0700

> +static int lio_set_link_ksettings(struct net_device *netdev,
> +				  const struct ethtool_link_ksettings *ecmd)
> +{
> +	struct lio *lio = GET_LIO(netdev);
> +	struct octeon_device *oct = lio->oct_dev;
> +	struct oct_link_info *linfo;
> +	const int speed = ecmd->base.speed;
> +	u32 is25G = 0;

Please order local variable declarations from longest to shortest line,
as was properly done in the rest of this patch.

Thank you.