netdev - Re: [PATCH net-next] net: stmmac: Add support for U32 TC filter using Flexible RX Parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180503175744.6dc32fb9@cakuba.netronome.com>
Date:   Thu, 3 May 2018 17:57:44 -0700
From:   Jakub Kicinski <kubakici@...pl>
To:     Jose Abreu <Jose.Abreu@...opsys.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Joao Pinto <Joao.Pinto@...opsys.com>,
        Vitor Soares <Vitor.Soares@...opsys.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>
Subject: Re: [PATCH net-next] net: stmmac: Add support for U32 TC filter
 using Flexible RX Parser

On Thu,  3 May 2018 13:45:30 +0100, Jose Abreu wrote:
> +	case TC_SETUP_CLSU32:
> +		if (!(priv->dev->hw_features & NETIF_F_HW_TC))
> +			ret = -EOPNOTSUPP;
> +		else
> +			ret = stmmac_tc_setup_cls_u32(priv, priv, type_data);
> +		break;

Please just use tc_cls_can_offload_and_chain0().  The extack message it
sets is useful for debugging and you don't support chains other than 0
either.