netdev - Re: [iproute2-next 1/1] tipc: Add support to set and get MTU for UDP bearer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 7 May 2018 07:46:26 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     GhantaKrishnamurthy MohanKrishna 
        <mohan.krishna.ghanta.krishnamurthy@...csson.com>
Cc:     <tipc-discussion@...ts.sourceforge.net>, <jon.maloy@...csson.com>,
        <maloy@...jonn.com>, <ying.xue@...driver.com>,
        <netdev@...r.kernel.org>, <davem@...emloft.net>,
        <dsahern@...il.com>
Subject: Re: [iproute2-next  1/1] tipc: Add support to set and get MTU for
 UDP bearer

On Mon, 7 May 2018 13:14:33 +0200
GhantaKrishnamurthy MohanKrishna         <mohan.krishna.ghanta.krishnamurthy@...csson.com> wrote:

> +				struct opt *opts)
> +{
> +	struct opt *opt;
> +
> +	if (!(opt = get_opt(opts, "media"))) {

You don't need to have assignment in conditional context in this case.
Please split the assignment and the if.