netdev - Re: [PATCH net-next] net:sched: add gkprio scheduler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <273f91db-7a2f-acda-b306-5a78dd948478@digirati.com.br>
Date:   Tue, 8 May 2018 08:59:34 -0400
From:   Michel Machado <michel@...irati.com.br>
To:     Nishanth Devarajan <ndev2021@...il.com>,
        Cong Wang <xiyou.wangcong@...il.com>
Cc:     jiri@...nulli.us, jhs@...atatu.com, davem@...emloft.net,
        netdev@...r.kernel.org, doucette@...edu
Subject: Re: [PATCH net-next] net:sched: add gkprio scheduler

>> Overall it looks good to me, just one thing below:
>>
>>> +struct Qdisc_ops gkprio_qdisc_ops __read_mostly = {
>>> +       .id             =       "gkprio",
>>> +       .priv_size      =       sizeof(struct gkprio_sched_data),
>>> +       .enqueue        =       gkprio_enqueue,
>>> +       .dequeue        =       gkprio_dequeue,
>>> +       .peek           =       qdisc_peek_dequeued,
>>> +       .init           =       gkprio_init,
>>> +       .reset          =       gkprio_reset,
>>> +       .change         =       gkprio_change,
>>> +       .dump           =       gkprio_dump,
>>> +       .destroy        =       gkprio_destroy,
>>> +       .owner          =       THIS_MODULE,
>>> +};
>>
>> You probably want to add Qdisc_class_ops here so that you can
>> dump the stats of each internal queue.

Hi Cong,

    In the production scenario we are targeting, this priority queue 
must be classless; being classful would only bloat the code for us. I 
don't see making this queue classful as a problem per se, but I suggest 
leaving it as a future improvement for when someone can come up with a 
useful scenario for it.

[ ]'s
Michel Machado