netdev - [PATCH] hv_netvsc: Fix net device attach on older Windows hosts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue,  8 May 2018 19:40:47 +0200
From:   Mohammed Gamal <mgamal@...hat.com>
To:     netdev@...r.kernel.org, sthemmin@...rosoft.com
Cc:     kys@...rosoft.com, haiyangz@...rosoft.com,
        devel@...uxdriverproject.org, vkuznets@...hat.com,
        linux-kernel@...r.kernel.org, Mohammed Gamal <mgamal@...hat.com>
Subject: [PATCH] hv_netvsc: Fix net device attach on older Windows hosts

On older windows hosts the net_device instance is returned to
the caller of rndis_filter_device_add() without having the presence
bit set first. This would cause any subsequent calls to network device
operations (e.g. MTU change, channel change) to fail after the device
is detached once, returning -ENODEV.

Make sure we explicitly call netif_device_attach() before returning
the net_device instance to make sure the presence bit is set

Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic")

Signed-off-by: Mohammed Gamal <mgamal@...hat.com>
---
 drivers/net/hyperv/rndis_filter.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
index 6b127be..09a3c1d 100644
--- a/drivers/net/hyperv/rndis_filter.c
+++ b/drivers/net/hyperv/rndis_filter.c
@@ -1287,8 +1287,10 @@ struct netvsc_device *rndis_filter_device_add(struct hv_device *dev,
 		   rndis_device->hw_mac_adr,
 		   rndis_device->link_state ? "down" : "up");
 
-	if (net_device->nvsp_version < NVSP_PROTOCOL_VERSION_5)
+	if (net_device->nvsp_version < NVSP_PROTOCOL_VERSION_5) {
+		netif_device_attach(net);
 		return net_device;
+	}
 
 	rndis_filter_query_link_speed(rndis_device, net_device);
 
-- 
1.8.3.1