netdev - Re: [PATCH net-next] dt-bindings: dsa: Remove unnecessary #address/#size-cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <926828d5-477a-514f-ac54-42dc7a263f5a@gmail.com>
Date:   Tue, 8 May 2018 13:58:12 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Fabio Estevam <festevam@...il.com>, davem@...emloft.net
Cc:     andrew@...n.ch, robh+dt@...nel.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, Fabio Estevam <fabio.estevam@....com>
Subject: Re: [PATCH net-next] dt-bindings: dsa: Remove unnecessary
 #address/#size-cells

On 05/07/2018 05:17 AM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@....com>
> 
> If the example binding is used on a real dts file, the following DTC
> warning is seen with W=1:
>     
> arch/arm/boot/dts/imx6q-b450v3.dtb: Warning (avoid_unnecessary_addr_size): /mdio-gpio/switch@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
> 
> Remove unnecessary #address-cells/#size-cells to improve the binding
> document examples.

In most cases this is unnecessary because the parent node is an MDIO,
I2C or SPI controller, and those typically have #address-cells = <1> and
#size-cells = <0> because of their specific binding, but this is not
necessarily true if using e.g: a MMIO mapped Ethernet switch.

With the particular example though, this appears fine:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian