netdev - Re: [PATCH] net/9p: correct some comment errors in 9p file system code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b888ec39-82dd-f950-c9be-796b02bd8c61@infradead.org>
Date:   Mon, 7 May 2018 18:20:31 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Sun Lianwen <sunlw.fnst@...fujitsu.com>, viro@...iv.linux.org.uk
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net/9p: correct some comment errors in 9p file system
 code

On 05/07/2018 05:45 PM, Sun Lianwen wrote:
> There are follow comment errors:
> 1 The function name is wrong in p9_release_pages() comment.
> 2 The function name and variable name is wrong in p9_poll_workfn() comment.
> 3 There is no variable dm_mr and lkey in struct p9_trans_rdma.
> 4 The function name is wrong in rdma_create_trans() comment.
> 5 There is no variable initialized in struct virtio_chan.
> 6 The variable name is wrong in p9_virtio_zc_request() comment.
> 
> Signed-off-by: Sun Lianwen <sunlw.fnst@...fujitsu.com>
> ---
>  net/9p/trans_common.c | 2 +-
>  net/9p/trans_fd.c     | 4 ++--
>  net/9p/trans_rdma.c   | 4 +---
>  net/9p/trans_virtio.c | 5 ++---
>  4 files changed, 6 insertions(+), 9 deletions(-)
> 
> diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c
> index 6d8e3031978f..88c71c0e95df 100644
> --- a/net/9p/trans_rdma.c
> +++ b/net/9p/trans_rdma.c
> @@ -632,7 +630,7 @@ static int p9_rdma_bind_privport(struct p9_trans_rdma *rdma)
>  }
>  
>  /**
> - * trans_create_rdma - Transport method for creating atransport instance
> + * rdma_create_trans - Transport method for creating atransport instance

                                                        a transport

>   * @client: client instance
>   * @addr: IP address string
>   * @args: Mount options string


-- 
~Randy