lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20180510.150613.1334467102643804220.davem@davemloft.net>
Date:   Thu, 10 May 2018 15:06:13 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     Jose.Abreu@...opsys.com
Cc:     netdev@...r.kernel.org, Joao.Pinto@...opsys.com,
        Vitor.Soares@...opsys.com, peppe.cavallaro@...com,
        alexandre.torgue@...com
Subject: Re: [PATCH net-next 01/10] net: stmmac: Let descriptor code set
 skbuff address

From: Jose Abreu <Jose.Abreu@...opsys.com>
Date: Tue,  8 May 2018 15:45:24 +0100

> Stop using if conditions depending on the GMAC version for setting the
> the descriptor skbuff address and use instead a helper implemented in
> the descriptor files.
> 
> Signed-off-by: Jose Abreu <joabreu@...opsys.com>

With Spectre mitigations, indirect calls are extremely expensive.  Much
more expensive than conditional checks.

And since this is the descriptor setup in the fast paths of the driver,
I advise that you keep these conditionals.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ