netdev - Re: [PATCH net-next] net: dsa: fix added_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180510.152719.500625126905254406.davem@davemloft.net>
Date:   Thu, 10 May 2018 15:27:19 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     vivien.didelot@...oirfairelinux.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...oirfairelinux.com, petrm@...lanox.com, jiri@...lanox.com,
        idosch@...lanox.com, ivecera@...hat.com,
        stephen@...workplumber.org, andrew@...n.ch, f.fainelli@...il.com,
        nikolay@...ulusnetworks.com, bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net-next] net: dsa: fix added_by_user switchdev
 notification

From: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Date: Tue,  8 May 2018 23:03:12 -0400

> Commit 161d82de1ff8 ("net: bridge: Notify about !added_by_user FDB
> entries") causes the below oops when bringing up a slave interface,
> because dsa_port_fdb_add is still scheduled, but with a NULL address.
> 
> To fix this, keep the dsa_slave_switchdev_event function agnostic of the
> notified info structure and handle the added_by_user flag in the
> specific dsa_slave_switchdev_event_work function.
 ...
> Fixes: 816a3bed9549 ("switchdev: Add fdb.added_by_user to switchdev notifications")
> Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

Applied, thanks Vivien.