netdev - Re: [PATCH net] udp: fix SO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180510.154323.2039328312941374514.davem@davemloft.net>
Date:   Thu, 10 May 2018 15:43:23 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, dnman@...etlabs.ru, dsahern@...il.com
Subject: Re: [PATCH net] udp: fix SO_BINDTODEVICE

From: Paolo Abeni <pabeni@...hat.com>
Date: Wed,  9 May 2018 12:42:34 +0200

> Damir reported a breakage of SO_BINDTODEVICE for UDP sockets.
> In absence of VRF devices, after commit fb74c27735f0 ("net:
> ipv4: add second dif to udp socket lookups") the dif mismatch
> isn't fatal anymore for UDP socket lookup with non null
> sk_bound_dev_if, breaking SO_BINDTODEVICE semantics.
> 
> This changeset addresses the issue making the dif match mandatory
> again in the above scenario.
> 
> Reported-by: Damir Mansurov <dnman@...etlabs.ru>
> Fixes: fb74c27735f0 ("net: ipv4: add second dif to udp socket lookups")
> Fixes: 1801b570dd2a ("net: ipv6: add second dif to udp socket lookups")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied.