netdev - Re: [PATCH net] net/mlx4_en: Verify coalescing parameters are in range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180510.160957.1777491913531231884.davem@davemloft.net>
Date:   Thu, 10 May 2018 16:09:57 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     tariqt@...lanox.com
Cc:     netdev@...r.kernel.org, eranbe@...lanox.com, moshe@...lanox.com
Subject: Re: [PATCH net] net/mlx4_en: Verify coalescing parameters are in
 range

From: Tariq Toukan <tariqt@...lanox.com>
Date: Wed,  9 May 2018 18:35:13 +0300

> From: Moshe Shemesh <moshe@...lanox.com>
> 
> Add check of coalescing parameters received through ethtool are within
> range of values supported by the HW.
> Driver gets the coalescing rx/tx-usecs and rx/tx-frames as set by the
> users through ethtool. The ethtool support up to 32 bit value for each.
> However, mlx4 modify cq limits the coalescing time parameter and
> coalescing frames parameters to 16 bits.
> Return out of range error if user tries to set these parameters to
> higher values.
> Change type of sample-interval and adaptive_rx_coal parameters in mlx4
> driver to u32 as the ethtool holds them as u32 and these parameters are
> not limited due to mlx4 HW.
> 
> Fixes: c27a02cd94d6 ('mlx4_en: Add driver for Mellanox ConnectX 10GbE NIC')
> Signed-off-by: Moshe Shemesh <moshe@...lanox.com>
> Signed-off-by: Tariq Toukan <tariqt@...lanox.com>

Applied and queued up for -stable.