netdev - Re: [iproute2-next 1/1] tipc: fixed node and name table listings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7e1086cd-292b-bd80-fdbb-f0840945f337@gmail.com>
Date:   Wed, 9 May 2018 21:57:11 -0600
From:   David Ahern <dsahern@...il.com>
To:     Jon Maloy <jon.maloy@...csson.com>, stephen@...workplumber.org,
        netdev@...r.kernel.org
Cc:     mohan.krishna.ghanta.krishnamurthy@...csson.com,
        tung.q.nguyen@...tech.com.au, hoang.h.le@...tech.com.au,
        canh.d.luu@...tech.com.au, ying.xue@...driver.com,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [iproute2-next 1/1] tipc: fixed node and name table listings

On 5/7/18 10:32 AM, Jon Maloy wrote:
> We make it easier for users to correlate between 128-bit node
> identities and 32-bit node hash by extending the 'node list'
> command to also show the hash value.
> 
> We also improve the 'nametable show' command to show the node identity
> instead of the node hash value. Since the former potentially is much
> longer than the latter, we make room for it by eliminating the (to the
> user) irrelevant publication key. We also reorder some of the columns
> so that the node id comes last, since this looks nicer and more logical.
> 
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>
> ---
>  tipc/misc.c      | 18 ++++++++++++++++++
>  tipc/misc.h      |  1 +
>  tipc/nametable.c | 18 ++++++++++--------
>  tipc/node.c      | 19 ++++++++-----------
>  tipc/peer.c      |  4 ++++
>  5 files changed, 41 insertions(+), 19 deletions(-)
> 

Hi Jon: I see new warnings with Debian stretch gcc:

tipc
    CC       misc.o
    CC       nametable.o
    CC       node.o
    CC       peer.o
misc.c: In function ‘hash2nodestr’:
misc.c:128:14: warning: pointer targets in passing argument 1 of
‘nodeid2str’ differ in signedness [-Wpointer-sign]
   nodeid2str(nr.node_id, str);
              ^~
misc.c:100:6: note: expected ‘uint8_t * {aka unsigned char *}’ but
argument is of type ‘char *’
 void nodeid2str(uint8_t *id, char *str)
      ^~~~~~~~~~