netdev - Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9bbc5be8-71e2-5aab-ce18-32eb8a612f21@intel.com>
Date:   Fri, 11 May 2018 08:43:16 -0700
From:   "Samudrala, Sridhar" <sridhar.samudrala@...el.com>
To:     Randy Dunlap <rdunlap@...radead.org>, mst@...hat.com,
        stephen@...workplumber.org, davem@...emloft.net,
        netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org,
        virtio-dev@...ts.oasis-open.org, jesse.brandeburg@...el.com,
        alexander.h.duyck@...el.com, kubakici@...pl, jasowang@...hat.com,
        loseweigh@...il.com, jiri@...nulli.us, aaron.f.brown@...el.com
Subject: Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

On 5/7/2018 3:39 PM, Randy Dunlap wrote:
> Hi,
>
> On 05/07/2018 03:10 PM, Sridhar Samudrala wrote:
>> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@...el.com>
>> ---
>>   MAINTAINERS                |    7 +
>>   include/linux/netdevice.h  |   16 +
>>   include/net/net_failover.h |   52 +++
>>   net/Kconfig                |   10 +
>>   net/core/Makefile          |    1 +
>>   net/core/net_failover.c    | 1044 ++++++++++++++++++++++++++++++++++++++++++++
>>   6 files changed, 1130 insertions(+)
>>   create mode 100644 include/net/net_failover.h
>>   create mode 100644 net/core/net_failover.c
>
>> diff --git a/net/Kconfig b/net/Kconfig
>> index b62089fb1332..0540856676de 100644
>> --- a/net/Kconfig
>> +++ b/net/Kconfig
>> @@ -429,6 +429,16 @@ config MAY_USE_DEVLINK
>>   config PAGE_POOL
>>          bool
>>   
>> +config NET_FAILOVER
>> +	tristate "Failover interface"
>> +	default m
> Need some justification for default m (as opposed to n).

default n should be fine.  It will get selected automatically when virtio_net or
netvsc are enabled. will fix in the next revision.


>
>