netdev - Re: [PATCH v2 net-next] tcp: switch pacing timer to softirq based hrtimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180511.122451.2213108692459459436.davem@davemloft.net>
Date:   Fri, 11 May 2018 12:24:51 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH v2 net-next] tcp: switch pacing timer to softirq based
 hrtimer

From: Eric Dumazet <edumazet@...gle.com>
Date: Thu, 10 May 2018 14:59:43 -0700

> linux-4.16 got support for softirq based hrtimers.
> TCP can switch its pacing hrtimer to this variant, since this
> avoids going through a tasklet and some atomic operations.
> 
> pacing timer logic looks like other (jiffies based) tcp timers.
> 
> v2: use hrtimer_try_to_cancel() in tcp_clear_xmit_timers()
>     to correctly release reference on socket if needed.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Looks great, applied, thanks Eric.