netdev - Re: [PATCH net-next v2 2/3] sctp: add asoc and packet to sctp_flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 13 May 2018 18:40:47 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     netdev@...r.kernel.org
Cc:     linux-sctp@...r.kernel.org, Neil Horman <nhorman@...driver.com>,
        Vlad Yasevich <vyasevich@...il.com>,
        Xin Long <lucien.xin@...il.com>
Subject: Re: [PATCH net-next v2 2/3] sctp: add asoc and packet to
 sctp_flush_ctx

On Sat, May 12, 2018 at 07:21:51PM -0300, Marcelo Ricardo Leitner wrote:
> @@ -1043,20 +1038,17 @@ static bool sctp_outq_flush_rtx(struct sctp_flush_ctx *ctx,
>  static void sctp_outq_flush_data(struct sctp_flush_ctx *ctx,
>  				 int rtx_timeout)
>  {
> -	struct sctp_packet *packet = ctx->transport ? &ctx->transport->packet :
> -				     NULL;
> -	struct sctp_association *asoc = ctx->q->asoc;
>  	struct sctp_chunk *chunk;
>  	enum sctp_xmit status;
>
>  	/* Is it OK to send data chunks?  */
> -	switch (asoc->state) {
> +	switch (ctx->asoc->state) {
>  	case SCTP_STATE_COOKIE_ECHOED:
>  		/* Only allow bundling when this packet has a COOKIE-ECHO
>  		 * chunk.
>  		 */
> -		if (!packet || !packet->has_cookie_echo)
> -			return;
> +		if (!ctx->packet || !ctx->packet->has_cookie_echo)
> +			break;

This return/break change was by mistake. Will post v3 tomorrow.