netdev - Re: [PATCH] net/smc: check for missing nlattrs in SMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180514.164117.792209096555574754.davem@davemloft.net>
Date:   Mon, 14 May 2018 16:41:17 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ebiggers3@...il.com
Cc:     ubraun@...ux.ibm.com, tmricht@...ux.vnet.ibm.com,
        linux-s390@...r.kernel.org, netdev@...r.kernel.org,
        syzkaller-bugs@...glegroups.com, linux-kernel@...r.kernel.org,
        ebiggers@...gle.com
Subject: Re: [PATCH] net/smc: check for missing nlattrs in SMC_PNETID
 messages

From: Eric Biggers <ebiggers3@...il.com>
Date: Sun, 13 May 2018 17:01:30 -0700

> From: Eric Biggers <ebiggers@...gle.com>
> 
> It's possible to crash the kernel in several different ways by sending
> messages to the SMC_PNETID generic netlink family that are missing the
> expected attributes:
> 
> - Missing SMC_PNETID_NAME => null pointer dereference when comparing
>   names.
> - Missing SMC_PNETID_ETHNAME => null pointer dereference accessing
>   smc_pnetentry::ndev.
> - Missing SMC_PNETID_IBNAME => null pointer dereference accessing
>   smc_pnetentry::smcibdev.
> - Missing SMC_PNETID_IBPORT => out of bounds array access to
>   smc_ib_device::pattr[-1].
> 
> Fix it by validating that all expected attributes are present and that
> SMC_PNETID_IBPORT is nonzero.
> 
> Reported-by: syzbot+5cd61039dc9b8bfa6e47@...kaller.appspotmail.com
> Fixes: 6812baabf24d ("smc: establish pnet table management")
> Cc: <stable@...r.kernel.org> # v4.11+
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Applied and queued up for -stable, thanks.