netdev - Re: [PATCH] [PATCH net v3] ipv6: remove min MTU check for ipsec tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180513.201421.130627314998062804.davem@davemloft.net>
Date:   Sun, 13 May 2018 20:14:21 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ashwanth@...eaurora.org
Cc:     netdev@...r.kernel.org, pabeni@...hat.com, dsahern@...il.com,
        eric.dumazet@...il.com
Subject: Re: [PATCH] [PATCH net v3] ipv6: remove min MTU check for ipsec
 tunnels

From: Ashwanth Goli <ashwanth@...eaurora.org>
Date: Thu, 10 May 2018 23:15:44 +0530

> With 749439bfac "fix udpv6 sendmsg crash caused by too small MTU"
> ipsec tunnels that report a MTU less than IPV6_MIN_MTU are broken
> even for packets that are smaller than IPV6_MIN_MTU.
> 
> According to rfc2473#section-7.1
> 
>     if the original IPv6 packet is equal or  smaller  than  the
>     IPv6 minimum link MTU, the tunnel entry-point node
>     encapsulates the original packet, and subsequently
>     fragments the resulting IPv6 tunnel packet into IPv6
>     fragments that do not exceed the Path MTU to the tunnel
>     exit-point.
> 
> Dropping the MTU check for ipsec tunnel destinations.
> 
> Signed-off-by: Ashwanth Goli <ashwanth@...eaurora.org>

I still hold the fundamental objection to your change which I expressed
from the beginning.

I'll try to be more clear.

This RFC language is talking about tunnels _IN GENERAL_.

Your patch is modifying behavior only for IPSEC tunnels.

That doesn't make any sense.

Either the RFC language is to be followed, and therefore applied
to all tunnels.  Or it doesn't.

I don't see any logic which makes it such that only IPSEC tunnels
should follow this MTU checking rule.

Please do not resubmit this patch again until you resolve this
issue.

Thank you.