netdev - Re: [PATCH net] xfrm6: avoid potential infinite loop in _decode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180513.202349.1985276646648462963.davem@davemloft.net>
Date:   Sun, 13 May 2018 20:23:49 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        steffen.klassert@...unet.com, nicolas.dichtel@...nd.com
Subject: Re: [PATCH net] xfrm6: avoid potential infinite loop in
 _decode_session6()

From: Eric Dumazet <edumazet@...gle.com>
Date: Sat, 12 May 2018 02:49:30 -0700

> syzbot found a way to trigger an infinitie loop by overflowing
> @offset variable that has been forced to use u16 for some very
> obscure reason in the past.
> 
> We probably want to look at NEXTHDR_FRAGMENT handling which looks
> wrong, in a separate patch.
> 
> In net-next, we shall try to use skb_header_pointer() instead of
> pskb_may_pull().
 ...
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Steffen Klassert <steffen.klassert@...unet.com>
> Cc: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> Reported-by: syzbot+0053c8...@...kaller.appspotmail.com

Steffen, I am assuming you will pick this up.

Thank you.