netdev - Re: [PATCH net] cxgb4: Correct ntuple mask validation for hash filters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180514.224339.2257632415415759949.davem@davemloft.net>
Date:   Mon, 14 May 2018 22:43:39 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ganeshgr@...lsio.com
Cc:     netdev@...r.kernel.org, nirranjan@...lsio.com,
        indranil@...lsio.com, venkatesh@...lsio.com,
        rahul.lakkireddy@...lsio.com, kumaras@...lsio.com
Subject: Re: [PATCH net] cxgb4: Correct ntuple mask validation for hash
 filters

From: Ganesh Goudar <ganeshgr@...lsio.com>
Date: Mon, 14 May 2018 16:27:34 +0530

> From: Kumar Sanghvi <kumaras@...lsio.com>
> 
> Earlier code of doing bitwise AND with field width bits was wrong.
> Instead, simplify code to calculate ntuple_mask based on supplied
> fields and then compare with mask configured in hw - which is the
> correct and simpler way to validate ntuple mask.
> 
> Fixes: 3eb8b62d5a26 ("cxgb4: add support to create hash-filters via tc-flower offload")
> Signed-off-by: Kumar Sanghvi <kumaras@...lsio.com>
> Signed-off-by: Ganesh Goudar <ganeshgr@...lsio.com>

Applied and queued up for -stable.