netdev - Re: [PATCH bpf-next v6 0/4] Hash support for sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58b2e8fa-87e6-ea7f-b96c-f5be6f48b4be@iogearbox.net>
Date:   Tue, 15 May 2018 20:55:53 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     John Fastabend <john.fastabend@...il.com>, ast@...nel.org
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH bpf-next v6 0/4] Hash support for sock

On 05/14/2018 07:00 PM, John Fastabend wrote:
> In the original sockmap implementation we got away with using an
> array similar to devmap. However, unlike devmap where an ifindex
> has a nice 1:1 function into the map we have found some use cases
> with sockets that need to be referenced using longer keys.
> 
> This series adds support for a sockhash map reusing as much of
> the sockmap code as possible. I made the decision to add sockhash
> specific helpers vs trying to generalize the existing helpers
> because (a) they have sockmap in the name and (b) the keys are
> different types. I prefer to be explicit here rather than play
> type games or do something else tricky.
> 
> To test this we duplicate all the sockmap testing except swap out
> the sockmap with a sockhash.
> 
> v2: fix file stats and add v2 tag
> v3: move tool updates into test patch, move bpftool updates into
>     its own patch, and fixup the test patch stats to catch the
>     renamed file and provide only diffs +/- on that.
> v4: Add documentation to UAPI bpf.h
> v5: Add documentation to tools UAPI bpf.h
> v6: 'git add' test_sockhash_kern.c which was previously missing
>     but was not causing issues because of typo in test script,
>     noticed by Daniel. After this the git format-patch -M option
>     no longer tracks the rename of the test_sockmap_kern files for
>     some reason. I guess the diff has exceeded some threshold.
> 
> Just a note I pushed Dave's Acks through v4 into v5 due to small
> size of changes.
> 
> John Fastabend (4):
>   bpf: sockmap, refactor sockmap routines to work with hashmap
>   bpf: sockmap, add hash map support
>   bpf: selftest additions for SOCKHASH
>   bpf: bpftool, support for sockhash

Applied to bpf-next, thanks John! Couple of comments in the patches.