netdev - Re: [iproute2] Bug#898840: Latest update breaks ip6 default gateway cli api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180516145344.fle2t7qng7cvowsu@unicorn.suse.cz>
Date:   Wed, 16 May 2018 16:53:44 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     netdev@...r.kernel.org
Cc:     Serhey Popovych <serhe.popovych@...il.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Hans van Kranenburg <hans.van.kranenburg@...dix.com>,
        898840@...s.debian.org, Luca Boccassi <bluca@...ian.org>
Subject: Re: [iproute2] Bug#898840: Latest update breaks ip6 default gateway
 cli api

On Wed, May 16, 2018 at 02:42:24PM +0100, Luca Boccassi wrote:
> Hans reported a regression in v4.16.0, ip route now requires -6 to be
> manually added when using v6 addresses while up to 4.15 it didn't, the
> commands quoted show the problem.
> 
> Bisecting shows that the following commit from Serhey introduced the
> problem:
> 
> 93fa12418dc6f5943692250244be303bb162175b
> utils: Always specify family and ->bytelen in get_prefix_1()
> 
> Could you please have a look when you have a moment? It's very easy to
> reproduce, and it breaks existing scripts and so on.

Fixed already:

------------------------------------------------------------------------------
mike@...corn:~/work/git/iproute2> git --no-pager log --grep 93fa12418dc6
commit d42c7891d26e4d5616a55aac9fe10813767fcf9c
Author: David Ahern <dsahern@...il.com>
Date:   Fri Apr 13 09:36:33 2018 -0700

    utils: Do not reset family for default, any, all addresses
    
    Thomas reported a change in behavior with respect to autodectecting
    address families. Specifically, 'ip ro add default via fe80::1'
    syntax was failing to treat fe80::1 as an IPv6 address as it did in
    prior releases. The root causes appears to be a change in family when
    the default keyword is parsed.
    
    'default', 'any' and 'all' are relevant outside of AF_INET. Leave the
    family arg as is for these when setting addr.
    
    Fixes: 93fa12418dc6 ("utils: Always specify family and ->bytelen in get_prefix_1()")
    Reported-by: Thomas Deutschmann <whissi@...too.org>
    Signed-off-by: David Ahern <dsahern@...il.com>
    Cc: Serhey Popovych <serhe.popovych@...il.com>
------------------------------------------------------------------------------

Michal Kubecek