netdev - Re: [RESEND PATCH v2 1/1] net: phy: micrel: add 125MHz reference clock workaround

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180516.122114.346848669661017521.davem@davemloft.net>
Date:   Wed, 16 May 2018 12:21:14 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     m.felsch@...gutronix.de
Cc:     robh+dt@...nel.org, mark.rutland@....com, andrew@...n.ch,
        f.fainelli@...il.com, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, kernel@...gutronix.de, niebelm@...c.de
Subject: Re: [RESEND PATCH v2 1/1] net: phy: micrel: add 125MHz reference
 clock workaround

From: Marco Felsch <m.felsch@...gutronix.de>
Date: Tue, 15 May 2018 10:18:56 +0200

> From: Markus Niebel <Markus.Niebel@....de>
> 
> The micrel KSZ9031 phy has a optional clock pin (CLK125_NDO) which can be
> used as reference clock for the MAC unit. The clock signal must meet the
> RGMII requirements to ensure the correct data transmission between the
> MAC and the PHY. The KSZ9031 phy does not fulfill the duty cycle
> requirement if the phy is configured as slave. For a complete
> describtion look at the errata sheets: DS80000691D or DS80000692D.
> 
> The errata sheet recommends to force the phy into master mode whenever
> there is a 1000Base-T link-up as work around. Only set the
> "micrel,force-master" property if you use the phy reference clock provided
> by CLK125_NDO pin as MAC reference clock in your application.
> 
> Attenation, this workaround is only usable if the link partner can
> be configured to slave mode for 1000Base-T.
> 
> Signed-off-by: Markus Niebel <Markus.Niebel@....de>
> [m.felsch@...gutronix.de: fix dt-binding documentation]
> [m.felsch@...gutronix.de: use already existing result var for read/write]
> [m.felsch@...gutronix.de: add error handling]
> [m.felsch@...gutronix.de: add more comments]
> Signed-off-by: Marco Felsch <m.felsch@...gutronix.de>

Applied, thank you.