netdev - RE: [PATCH net-next v2 4/4] bonding: allow carrier and link status to determine link state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fdc5f4772d1f4a4b89c533b5ef6c3db5@usma1ex-dag1mb2.msg.corp.akamai.com>
Date:   Wed, 16 May 2018 17:14:07 +0000
From:   "Banerjee, Debabrata" <dbanerje@...mai.com>
To:     'David Miller' <davem@...emloft.net>
CC:     "jay.vosburgh@...onical.com" <jay.vosburgh@...onical.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "vfalico@...il.com" <vfalico@...il.com>,
        "andy@...yhouse.net" <andy@...yhouse.net>
Subject: RE: [PATCH net-next v2 4/4] bonding: allow carrier and link status to
 determine link state

> From: David Miller [mailto:davem@...emloft.net]
> 
> Looking at the bnx2x driver, it's management of link state is very convoluted.
> 
> The link parameters and the "link_up" state is maintained separately from
> the values that are snapshot when the carrier is enabled.
...
> If the carrier is up, you should be able to provide the link speed and duplex
> values immediately not some indeterminate amount of time later.

This was steady state, the machine was stuck like this for hours/days.


> I don't think we should reward drivers for behaving this way.

I'll send v3 without this patch.