netdev - Re: [PATCH net-next V2 1/2] cxgb4: Add support for FW_ETH_TX_PKT_VM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180516.150051.2174001691406681581.davem@davemloft.net>
Date:   Wed, 16 May 2018 15:00:51 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ganeshgr@...lsio.com
Cc:     netdev@...r.kernel.org, nirranjan@...lsio.com,
        indranil@...lsio.com, venkatesh@...lsio.com, arjun@...lsio.com,
        leedom@...lsio.com
Subject: Re: [PATCH net-next V2 1/2] cxgb4: Add support for
 FW_ETH_TX_PKT_VM_WR

From: Ganesh Goudar <ganeshgr@...lsio.com>
Date: Wed, 16 May 2018 18:40:47 +0530

> @@ -554,6 +563,7 @@ struct port_info {
>  	struct hwtstamp_config tstamp_config;
>  	bool ptp_enable;
>  	struct sched_table *sched_tbl;
> +	u32 eth_flags;
>  };
>  
>  struct dentry;
> @@ -864,6 +874,7 @@ struct adapter {
>  	unsigned int flags;
>  	unsigned int adap_idx;
>  	enum chip_type chip;
> +	unsigned int eth_flags;

Both of these new struct members should use the same type.

But see my feedback for patch #2 first.