netdev - Re: [PATCH bpf-next v6 2/4] bpf: sockmap, add hash map support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30a331f8-ee31-747d-123f-5105076c690c@iogearbox.net>
Date:   Wed, 16 May 2018 22:08:18 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Y Song <ys114321@...il.com>
Cc:     John Fastabend <john.fastabend@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH bpf-next v6 2/4] bpf: sockmap, add hash map support

On 05/15/2018 11:09 PM, Y Song wrote:
> On Tue, May 15, 2018 at 12:01 PM, Daniel Borkmann <daniel@...earbox.net> wrote:
>> On 05/14/2018 07:00 PM, John Fastabend wrote:
[...]
>>>  enum bpf_prog_type {
>>> @@ -1855,6 +1856,52 @@ struct bpf_stack_build_id {
>>>   *             Egress device index on success, 0 if packet needs to continue
>>>   *             up the stack for further processing or a negative error in case
>>>   *             of failure.
>>> + * int bpf_sock_hash_update(struct bpf_sock_ops_kern *skops, struct bpf_map *map, void *key, u64 flags)
>>
>> When you rebase please fix this up properly next time and add a newline in between
>> the helpers. I fixed this up while applying.
> 
> I guess the tools/include/uapi/linux/bpf.h may also need fixup to be
> in sync with main bpf.h.

Yep agree, just fixed it up, thanks!