netdev - Re: [PATCH 1/3] sh_eth: add RGMII support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <252cbfe6-ed4b-aebb-e5b7-1b60cec7fb69@cogentembedded.com>
Date:   Wed, 16 May 2018 23:34:25 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 1/3] sh_eth: add RGMII support

On 05/16/2018 11:30 PM, Andrew Lunn wrote:

>> The R-Car V3H (AKA R8A77980) GEther controller  adds support for the RGMII
>> PHY interface mode as a new  value  for the RMII_MII register.
>>
>> Based on the original (and large) patch by Vladimir Barinov.
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@...entembedded.com>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
>>
>> ---
>>  drivers/net/ethernet/renesas/sh_eth.c |    3 +++
>>  1 file changed, 3 insertions(+)
>>
>> Index: net-next/drivers/net/ethernet/renesas/sh_eth.c
>> ===================================================================
>> --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c
>> +++ net-next/drivers/net/ethernet/renesas/sh_eth.c
>> @@ -466,6 +466,9 @@ static void sh_eth_select_mii(struct net
>>  	u32 value;
>>  
>>  	switch (mdp->phy_interface) {
>> +	case PHY_INTERFACE_MODE_RGMII:
>> +		value = 0x3;
>> +		break;
> 
> Hi Sergei
> 
> What about
> 	PHY_INTERFACE_MODE_RGMII_ID,
> 	PHY_INTERFACE_MODE_RGMII_RXID,
> 	PHY_INTERFACE_MODE_RGMII_TXID,

   Oops, totally forgot about those... :-/

>      Andrew

MBR, Sergei