netdev - Re: [PATCH iproute2-next] tc-netem: fix limit description in man page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180516142825.1a11dcf2@xeon-e3>
Date:   Wed, 16 May 2018 14:28:25 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     David Ahern <dsahern@...il.com>
Cc:     Marcelo Ricardo Leitner <mleitner@...hat.com>,
        netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next] tc-netem: fix limit description in man
 page

On Wed, 16 May 2018 15:17:50 -0600
David Ahern <dsahern@...il.com> wrote:

> On 5/15/18 6:49 PM, Marcelo Ricardo Leitner wrote:
> > As the kernel code says, limit is actually the amount of packets it can
> > hold queued at a time, as per:
> > 
> > static int netem_enqueue(struct sk_buff *skb, struct Qdisc *sch,
> >                          struct sk_buff **to_free)
> > {
> > 	...
> >         if (unlikely(sch->q.qlen >= sch->limit))
> >                 return qdisc_drop_all(skb, sch, to_free);
> > 
> > So lets fix the description of the field in the man page.
> > 
> > Signed-off-by: Marcelo Ricardo Leitner <mleitner@...hat.com>
> > ---
> >  man/man8/tc-netem.8 | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >   
> 
> applied to iproute2-next. Thanks,
> 

Since it is an error, I will put it in master.