netdev - Re: linux-next: BUG: KASAN: use-after-free in tun_chr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4e3d8bad-e907-e917-50d4-4a0820409110@redhat.com>
Date:   Wed, 16 May 2018 15:52:11 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Andrei Vagin <avagin@...tuozzo.com>
Cc:     netdev@...r.kernel.org
Subject: Re: linux-next: BUG: KASAN: use-after-free in tun_chr_close



On 2018年05月16日 15:40, Andrei Vagin wrote:
> On Wed, May 16, 2018 at 03:32:59PM +0800, Jason Wang wrote:
>> On 2018年05月16日 15:12, Andrei Vagin wrote:
>>> Hi Jason,
>>>
>>> I think the problem is in "tun: hold a tun socket during ptr_ring_cleanup".
>>>
>>> Pls take a look at the attached patch.
>> Yes.
>>
>> It looks to me it's not necessary to take extra refcnt during release, we
>> can just do the cleanup at __tun_detach().
>>
>> Could you help to test the attached patch?
> I've run my test on the kernel with this patch. It fixes the problem.
> The patch looks correct for me.
>
> Acked-by: Andrei Vagin<avagin@...tuozzo.com>
>

Cool, thanks a lot!

Let me post a formal patch.