netdev - Re: [PATCH net-next] net: NET_VENDOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef0568f1-58c9-b211-866a-24a6e985b706@cogentembedded.com>
Date:   Thu, 17 May 2018 19:02:16 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org
Cc:     alexandre.belloni@...tlin.com
Subject: Re: [PATCH net-next] net: NET_VENDOR_MICROSEMI should default ot N

On 05/17/2018 06:43 PM, David Ahern wrote:

> Other ethernet drivers default to N. There is no reason for Microsemi
> to default to y. I believe Linus has set the bar at a feature that cures
> cancer can be enabled by default. [1]
> 
> [1] https://lkml.org/lkml/2010/3/2/366
> 
> Signed-off-by: David Ahern <dsahern@...il.com>
> ---
>  drivers/net/ethernet/mscc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mscc/Kconfig b/drivers/net/ethernet/mscc/Kconfig
> index 36c84625d54e..0ef40b05c8af 100644
> --- a/drivers/net/ethernet/mscc/Kconfig
> +++ b/drivers/net/ethernet/mscc/Kconfig
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: (GPL-2.0 OR MIT)
>  config NET_VENDOR_MICROSEMI
>  	bool "Microsemi devices"
> -	default y
> +	default n

   You know that N is the default default? :-)

[...]

MBR, Sergei