netdev - Re: [PATCH v2 net] stmmac: strip vlan tag on reception only for 8021q tagged frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180517.124356.1373521143004050823.davem@davemloft.net>
Date:   Thu, 17 May 2018 12:43:56 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     eladv6@...il.com
Cc:     makita.toshiaki@....ntt.co.jp, netdev@...r.kernel.org,
        peppe.cavallaro@...com, alexandre.torgue@...com
Subject: Re: [PATCH v2 net] stmmac: strip vlan tag on reception only for
 8021q tagged frames

From: Elad Nachman <eladv6@...il.com>
Date: Fri, 11 May 2018 10:31:40 +0300

> stmmac reception handler calls stmmac_rx_vlan() to strip the vlan
> before calling napi_gro_receive().
> 
> The function assumes VLAN tagged frames are always tagged with
> 802.1Q protocol, and assigns ETH_P_8021Q to the skb by hard-coding
> the parameter on call to __vlan_hwaccel_put_tag() without checking
> the actual VLAN tag.
> 
> This causes packets not to be passed to the VLAN slave if it was
> created with 802.1AD protocol (ip link add link eth0 eth0.100 type
> vlan proto 802.1ad id 100).
> 
> This fix only strips the VLAN tag for 802.1Q tagged
> protocols. 802.1AD frames will be handled later by skb_vlan_untag().
> 
> Signed-off-by: Elad Nachman <eladn@...at.com>

Giuseppe and Alexandre, please review this patch.