netdev - Re: [patch net-next] nfp: flower: set sysfs link to device for representors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180517105123.7fea2de0@cakuba>
Date:   Thu, 17 May 2018 10:51:23 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jiri Pirko <jiri@...nulli.us>, Or Gerlitz <gerlitz.or@...il.com>
Cc:     Linux Netdev List <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Simon Horman <simon.horman@...ronome.com>,
        Dirk van der Merwe <dirk.vandermerwe@...ronome.com>,
        John Hurley <john.hurley@...ronome.com>,
        Pieter Jansen van Vuuren 
        <pieter.jansenvanvuuren@...ronome.com>, oss-drivers@...ronome.com,
        Jan Gutter <jan.gutter@...ronome.com>
Subject: Re: [patch net-next] nfp: flower: set sysfs link to device for
 representors

On Thu, 17 May 2018 14:42:10 +0200, Jiri Pirko wrote:
> Thu, May 17, 2018 at 02:25:14PM CEST, gerlitz.or@...il.com wrote:
> >On Thu, May 17, 2018 at 1:05 PM, Jiri Pirko <jiri@...nulli.us> wrote:  
> >> From: Jiri Pirko <jiri@...lanox.com>
> >>
> >> Do this so the sysfs has "device" link correctly set.  
> >
> >please no
> >
> >This is likely to create bunch of issues with respect to how libvirt
> >deals with the representors.  
> 
> Once netdev is there because of some probed pci device, this link should
> be set. That is one of the basics.
> 
> What "bunch of issues" are you talking about? Please be specific.

Libvirt may pick any device under sys/bus/pci/devices/$vf/physfn/net/
to run legacy SR-IOV NDOs on.  nfp currently exposes those on all
representors.  

Or correctly points out that running SR-IOV NDOs on non-PF reprs makes
very limited amount of sense and we should fix libvirt and remove the
NDOs for non-PF nfp reprs.

AFAICT since nfp does provide the NDOs on all reprs nothing should
break with this patch, but ip link will now start listing VF state on
each representor.  Meaning that if we have 100 VFs enabled simple "ip
link list" will produce upwards of 10,000 lines of output.