netdev - Re: [patch net-next] nfp: flower: fix error path during representor creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180517105637.0328a0ab@cakuba>
Date:   Thu, 17 May 2018 10:56:37 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        simon.horman@...ronome.com, dirk.vandermerwe@...ronome.com,
        john.hurley@...ronome.com, pieter.jansenvanvuuren@...ronome.com,
        oss-drivers@...ronome.com
Subject: Re: [patch net-next] nfp: flower: fix error path during representor
 creation

On Thu, 17 May 2018 12:06:43 +0200, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...lanox.com>
> 
> Don't store repr pointer to reprs array until the representor is
> successfully created. This avoids message about "representor
> destruction" even when it was never created. Also it cleans-up the flow.
> Also, check return value after port alloc.
> 
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Thank you!