netdev - Re: [PATCH] wcn36xx: Add support for Factory Test Mode (FTM)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58c8d2d16995e80f5527370e224045e2@codeaurora.org>
Date:   Thu, 17 May 2018 11:37:35 -0700
From:   Jeff Johnson <jjohnson@...eaurora.org>
To:     Ramon Fried <ramon.fried@...aro.org>
Cc:     kvalo@...eaurora.org, linux-kernel@...r.kernel.org,
        wcn36xx@...ts.infradead.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, Eyal Ilsar <eilsar@...eaurora.org>,
        linux-wireless-owner@...r.kernel.org
Subject: Re: [PATCH] wcn36xx: Add support for Factory Test Mode (FTM)

On 2018-05-17 04:32, Ramon Fried wrote:
> From: Eyal Ilsar <eilsar@...eaurora.org>
...
> +int wcn36xx_smd_process_ptt_msg(struct wcn36xx *wcn,
> +				struct ieee80211_vif *vif, void *ptt_msg, size_t len,
> +		void **ptt_rsp_msg)
> +{
> +	struct wcn36xx_hal_process_ptt_msg_req_msg *p_msg_body;
> +	int ret = 0;
> +
> +	mutex_lock(&wcn->hal_mutex);
> +	p_msg_body = kmalloc(
> +		sizeof(struct wcn36xx_hal_process_ptt_msg_req_msg) + len,
> +		GFP_ATOMIC);

NULL check required?

> +	INIT_HAL_PTT_MSG(p_msg_body, len);
> +