netdev - Re: [PATCH] net/ncsi: prevent a couple array underflows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180517.162807.2024433602650608102.davem@davemloft.net>
Date:   Thu, 17 May 2018 16:28:07 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     sam@...dozajonas.com, netdev@...r.kernel.org,
        gwshan@...ux.vnet.ibm.com, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] net/ncsi: prevent a couple array underflows

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Thu, 17 May 2018 15:33:36 +0300

> We recently refactored this code and introduced a static checker
> warning.  Smatch complains that if cmd->index is zero then we would
> underflow the arrays.  That's obviously true.
> 
> The question is whether we prevent cmd->index from being zero at a
> different level.  I've looked at the code and I don't immediately see
> a check for that.
> 
> Fixes: 062b3e1b6d4f ("net/ncsi: Refactor MAC, VLAN filters")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied to net-next, thanks Dan.