netdev - Re: [PATCH 1/4] arcnet: com20020: Add com20020 io mapped version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180517.163113.2110198960037727630.davem@davemloft.net>
Date:   Thu, 17 May 2018 16:31:13 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     andrea.greco.gapmilano@...il.com
Cc:     tobin@...orbit.com, a.greco@...gma.it, m.grzeschik@...gutronix.de,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 1/4] arcnet: com20020: Add com20020 io mapped version

From: Andrea Greco <andrea.greco.gapmilano@...il.com>
Date: Thu, 17 May 2018 15:05:29 +0200

> +	/* Will be set by userspace during if setup */
> +	dev->dev_addr[0] = 0;

Hmmm... really?

Also, every error path from this point forward will leak 'dev'.