netdev - Re: [PATCH v3 net-next 0/6] tcp: implement SACK compression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9ef582b7-b148-0ee1-65bd-8a272bb85a4f@gmail.com>
Date:   Fri, 18 May 2018 08:48:28 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     David Miller <davem@...emloft.net>, edumazet@...gle.com
Cc:     netdev@...r.kernel.org, toke@...e.dk, ncardwell@...gle.com,
        ycheng@...gle.com, soheil@...gle.com, eric.dumazet@...il.com
Subject: Re: [PATCH v3 net-next 0/6] tcp: implement SACK compression



On 05/18/2018 08:42 AM, David Miller wrote:

> This looks great, series applied, thanks Eric.
> 
> So now we handle locally terminated traffic well, however we still need
> something that handles traffic flowing through the system.  And for that
> reason the CAKE ACK filter still has merit.
> 
> I completely agree with you that it has to be implemented properly,
> parse all TCP options and the SACK blocks, and pass the ACKs through
> when there are options it doesn't understand or the SACK/timestampe/etc.
> update contains new information that must be passed along and not dropper.
> 
> Thanks again.
> 

Be assured I will carefully review Cake ACK filter ;)

Thanks David !